Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decommissioning problem in simulated test cases #29

Conversation

ccruzagralopes
Copy link
Contributor

@ccruzagralopes ccruzagralopes commented Nov 14, 2023

What changed

  • Updated SDK SHA to get the latest runner changes.
  • The runner's start and stop methods are now called only once each: start during test suite setup and stop during cleanup. stop is only called after asking the user to decommission.

Related issue

PR dependency

Testing

Ran one of each SDK YAML test cases and they were all executed as expected. The decommissioning after the simulated test case execution worked.

Screenshot 2023-11-14 at 14 24 27

app/chip_tool/chip_tool.py Show resolved Hide resolved
@ccruzagralopes ccruzagralopes merged commit 83958eb into project-chip:main Nov 23, 2023
8 checks passed
@ccruzagralopes ccruzagralopes deleted the 40-not_able_to_perform_decommissioning_in_simulated_test_case branch November 23, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants